Fix integer overflow in DMA allow list boundary check#298
Open
sameehj wants to merge 1 commit intowolfSSL:mainfrom
Open
Fix integer overflow in DMA allow list boundary check#298sameehj wants to merge 1 commit intowolfSSL:mainfrom
sameehj wants to merge 1 commit intowolfSSL:mainfrom
Conversation
Add overflow guards to _checkAddrAgainstAllowList to prevent address-space wraparound from bypassing the allow list on 32-bit and 64-bit systems. Reject requests where addr + size overflows, and skip allow list entries whose own range overflows. Signed-off-by: Sameeh Jubran <sameeh@wolfssl.com>
sameehj
requested review from
bigbrett and
billphipps
and removed request for
billphipps
Contributor
Author
|
The test failure is not related to this PR and has been addressed in the following PR: #301 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add overflow guards to _checkAddrAgainstAllowList to prevent address-space wraparound from bypassing the allow list on 32-bit and 64-bit systems. Reject requests where addr + size overflows, and skip allow list entries whose own range overflows.